-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add back 'Done' text on the button #3487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW you can remove type="primary"
too.
@deboer-tim yes good catch, amended |
There is something wrong, I pushed the commit but PR is not updated/new change is not there |
32c7073
to
7263a36
Compare
ok looks like it was lagging on github side... |
fixes containers#3251 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
removed the |
Yes, it has been very laggy today when I pushed too. |
What does this PR do?
add back 'Done' text on the button
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #3485
How to test this PR?
unit test or try the usecase of the issue